-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] manifest-version-format: Adds matching for string end to default manifest version format #155
[FIX] manifest-version-format: Adds matching for string end to default manifest version format #155
Conversation
…t manifest version format Issue OCA#152
@@ -234,7 +234,7 @@ | |||
DFTL_VALID_ODOO_VERSIONS = [ | |||
'4.2', '5.0', '6.0', '6.1', '7.0', '8.0', '9.0', '10.0' | |||
] | |||
DFTL_MANIFEST_VERSION_FORMAT = r"(%(valid_odoo_versions)s)\.\d+\.\d+\.\d+" | |||
DFTL_MANIFEST_VERSION_FORMAT = r"(%(valid_odoo_versions)s)\.\d+\.\d+\.\d+$" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ^
to "starts with" too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re.match()
, which is used in formatversion()
to check the version number checks from beginning of the string, so the ^
would be redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah!
You are right! (again!) 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you!
Change a wrong version module with this case in order to cover this one
…e end of module version
After merge OCA/pylint-odoo#155 we had this unexpected wrong format version
…ver the weblate-ssh server (#484) * [FIX] apis.py: Adding new metod _ssh_keyscan to run the ssh-keyscan over the weblate-ssh server (#233) * [REF] broken_deprecated: Use correct version format - After merge OCA/pylint-odoo#155 we had this unexpected wrong format version
…ver the weblate-ssh server (OCA#484) * [FIX] apis.py: Adding new metod _ssh_keyscan to run the ssh-keyscan over the weblate-ssh server (OCA#233) * [REF] broken_deprecated: Use correct version format - After merge OCA/pylint-odoo#155 we had this unexpected wrong format version
This adds
$
to the end of default manifest version format to disallow versions like10.0.1.0.0WHATEVER
.Related: #152